feat: implement coincap market service (fixes #281)

[Zerquix18]

Hello. This is the implementation of the CoinCap MarketService.

It follows the interface for MarketService and contains unit tests, all should be successful.

Two things to notice:

1. In the unit test, I'm directly instancing CoinCapService so that the mocks work. Since Coingecko is first in the list of providers, calling the functions in the parent directory causes a problem with the mocks.
2. I think coincap doesn't support smart contracts, so the coincapservice will throw an error if the CAIP19 is for a smart contract.

Tried to follow your conventions and make the code a similar to the coingecko service as possible
Let me know what you think :)

[0xdef1cafe]

hey @Zerquix18 thank you for the PR!

this is a great start, but i added some additional context of what needs to be done to get this working.

happy with what you did with the unit tests, that's the correct way to go about it.

the main thing is implementing the coincap caip adapter so we know how to talk to coincap correctly. unless @natven can confirm the ids are identical this won't work. in the case that they are, we should at least document it.

also, you'll need to lowercase your PR title, then push up a new commit. we use the angular preset for conventional commits https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-angular

i think you can do echo "feat: my commit message" | npx commitlint locally in the root of lib to check without pushing.

[Zerquix18]

Hi @0xdef1cafe
Thanks for your feedback! I'll be going through it

The only thing I didn't quite understand was the commit title. Do I have to change the commit history and submit a new PR?

[0xdef1cafe]

Hi @0xdef1cafe Thanks for your feedback! I'll be going through it

The only thing I didn't quite understand was the commit title. Do I have to change the commit history and submit a new PR?

hey - no need for a new PR. if you just change the title to

feat: implement coincap market service

and push any commit (which you will with your changes) it'll work fine :)

looking forward to seeing the changes

[Zerquix18]

@0xdef1cafe changed the title and added the adapter for coincap. All tests are passing.
Take a look when you have a chance 😄

[0xdef1cafe]

please see comments

[0xdef1cafe]

@Zerquix18 - hey, this is looking really good, few small cleanup changes requested and we can get this merged pretty soon

[0xdef1cafe]

@Zerquix18 also lint is failing CI - run yarn lint:fix from the root to fix things automatically.

[Zerquix18]

@0xdef1cafe Removed the scripts and ran the lint:fix command

[0xdef1cafe]

@Zerquix18 looks great, just gonna get one more approval from someone else in the team and we'll get this merged

[shapeshift-ci-bot]

🎉 This PR is included in version @shapeshiftoss/caip-v1.7.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[shapeshift-ci-bot]

🎉 This PR is included in version @shapeshiftoss/market-service-v1.6.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀