Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(idle): disable deposit on paused pools #4141

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Mar 27, 2023

Description

Blocked by shapeshift/lib#1226

This PR consumes the new exposed active property from investor-idle, and disables depositing on the Idle pools that aren't currently active.

Notice

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

Low, as long as upstream data is safu we're safu

Testing

  • Go to Idle opportunities by provider
  • Ensure that opportunities that are currently disabled upstream (can be cross-checked against Idle's UI) have their deposit disabled
  • Other opportunities should still allow depositing

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

0xdef1cafe
0xdef1cafe previously approved these changes Mar 27, 2023
Copy link
Collaborator

@0xdef1cafe 0xdef1cafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"approved", plz admin merge when package bumped

@gomesalexandre gomesalexandre marked this pull request as ready for review March 27, 2023 18:16
@gomesalexandre gomesalexandre requested a review from a team as a code owner March 27, 2023 18:16
@gomesalexandre gomesalexandre enabled auto-merge (squash) March 27, 2023 18:23
@gomesalexandre gomesalexandre disabled auto-merge March 27, 2023 18:23
@gomesalexandre gomesalexandre merged commit f2a4043 into develop Mar 27, 2023
@gomesalexandre gomesalexandre deleted the feat_idle_disable_inactive_pools branch March 27, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants