fix: rescue from internal errors instead of rest-client #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swarley
added a commit
that referenced
this pull request
Nov 28, 2021
* fix: Define path when filename is given to send_file (#92) * fix: Check roles method instead of role_ids * refactor: Move View to webhooks (#103) * refactor: Move View to webhooks * fix: Use Webhooks::View::COMPONENT_TYPES * fix: Correct use of positional argument in Webhook#execute * fix: Add alias with deprecation notice * feat!: Remove restricted channels check (#101) * refactor: Use chunk_index and chunk_count to determine chunk status. (#102) * refactor: Use chunk_index and chunk_count to determine chunk status. * refactor: additional chunking changes * fix: apply requested changes * fix: force guild recache from GUILD_CREATE (#104) * fix: rescue from internal errors instead of rest-client (#106) * feat: v4.0 API client WIP * feat: Add guild endpoints * feat: webhook endpoints * feat: Migrate to new API client internally * refactor: Use faraday in discordrb/webhooks. Switch gateway JSON to use symbols * refactor: Use faraday in discordrb/webhooks. Switch gateway JSON to use symbols * refactor!: Remove unsupported API methods * refactor!: Remove old API methods * fix: Remove further references to rest-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When migrating to v8 we bubbled up better-formatted errors based on the code provided from discord. Our cache methods were still rescuing from rest-client scoped errors instead of the discord equivalents.
Changed
Rescue from
Discordrb::Errors::Unknown*instead ofRestClient::ResourceNotFoundChannel#load_messageCache#userCache#memberCache#channel