Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for discord deprecations #179

Merged
merged 5 commits into from
Oct 9, 2022
Merged

Prepare for discord deprecations #179

merged 5 commits into from
Oct 9, 2022

Conversation

idk837384
Copy link
Contributor

@idk837384 idk837384 commented Oct 3, 2022

Summary

As of June 27, the $ prefix in the identify connection properties is deprecated. This PR removes the prefix to prepare for the deprecation.

~Removed the '$' prefix in the identify connection properties. Ex.
Old: '$browser': 'discordrb'
New: browser: 'discordrb'

Added

Changed

Deprecated

Removed

Deprecated features from gateway.rb

Fixed

@idk837384 idk837384 marked this pull request as ready for review October 3, 2022 04:55
@idk837384 idk837384 deleted the branch shardlab:main October 3, 2022 17:55
@idk837384 idk837384 closed this Oct 3, 2022
@idk837384 idk837384 deleted the main branch October 3, 2022 17:55
@idk837384 idk837384 restored the main branch October 3, 2022 17:56
@idk837384 idk837384 reopened this Oct 3, 2022
@idk837384
Copy link
Contributor Author

Accidentally closed it but re-opened it. I'm still somewhat unexperienced with github, sorry about that.

@swarley
Copy link
Member

swarley commented Oct 9, 2022

Thanks!

@swarley swarley merged commit a8df929 into shardlab:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants