Check if we have the SERVER_MEMBERS intent before fetching server members #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't change the intents while the gateway is open.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #51.
The gateway doesn't respond if we try to ask for server members without first declaring the intent. Originally,
Server#memberswould just wait for a response that isn't coming, causing it to never return. This change checks the intents we sent with the gateway first before requesting members.Added
Gateway#intents, the final calculated intents parameter sent to the gatewayServer#membersnow raises a RuntimeError if the gateway was not initialized with the SERVER_MEMBERS intent