Deprecate group DM endpoint methods #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The endpoints these methods call, while still functional, aren't meant for use by bots, and can't be called as implemented here.
Daniel-Worrall
added
the
documentation
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bots aren't allowed in group DMs, and while the API docs list a bunch of methods for managing group DMs, they aren't meant for bots to use, and don't work as currently implemented.
The API methods are meant to be used by the (deprecated) GameBridge SDK to invite people to a temporary "room" on Discord, relying on each party authenticating with an OAuth application separately.
Fixes #16
Deprecated
Discordrb::API::Channel.create_empty_group.create_group.add_group_user.remove_group_user.leave_group