Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use to_a to avoid rails problems #91

Merged
merged 2 commits into from
Sep 30, 2021
Merged

fix: Use to_a to avoid rails problems #91

merged 2 commits into from
Sep 30, 2021

Conversation

swarley
Copy link
Member

@swarley swarley commented Sep 21, 2021

Summary

I assume that rails isn't playing nicely with the use of to_json in Discordrb::Components::View. This refactors away to to_a directly to avoid it all together.

No public API changes.

@swarley swarley added the bug Something isn't working label Sep 21, 2021
@swarley swarley added this to the v3.5.0 milestone Sep 21, 2021
@swarley swarley merged commit 7c101bc into shardlab:main Sep 30, 2021
@swarley swarley deleted the fix/properly-serialize-view branch September 30, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@swarley