Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPhoneX bottomMargin of 34 seems quite high #3

Closed
syaau opened this issue Jan 29, 2019 · 1 comment
Closed

iPhoneX bottomMargin of 34 seems quite high #3

syaau opened this issue Jan 29, 2019 · 1 comment

Comments

@syaau
Copy link
Contributor

syaau commented Jan 29, 2019

We will have to look into this later (the bottom margin is quite high here)

Originally posted by @syaau in #2

@syaau
Copy link
Contributor Author

syaau commented Apr 9, 2019

Resorted to 16px marging

@syaau syaau closed this as completed Apr 9, 2019
syaau pushed a commit that referenced this issue Apr 10, 2019
* add DS_Store in gitignore

* add new calendar component

* update text with allowfontscaling property

* updates

* remove showdate prop

* updates

* update font color style

* add a funtion to get full date

* add left and right arrow in a stylesheet

* updates

* updates for calendar with memoization

* updates in calendar component

* refactor

* refactor code

* update style in header component

* changes in calendar

* add theme package

* merge with origin

* Update theme accessor to sharingapples

* resolve issue #5

* Resolve issue Unnecessary object initializations #2

* remove unused assets

* resolve issue #3 https://github.com/sharingapples/react-native-calendar/issues/3

* resolve issue #1 assets

* resolve issue #6 Make calendar a controlled component #6

* remove date if selected and pressed again

* add memoization to convert array to object

* update for typo

* showcase updates

* add remove multiple select option

* add calendar packages

* update access to calendar component

* updates for calendar packages

* updates for calendar with theme

* update index file to provide disabled value

* update readme and add readme to calendar package

* add link to package
syaau pushed a commit that referenced this issue Apr 10, 2019
…dates (#18)

* add DS_Store in gitignore

* add new calendar component

* update text with allowfontscaling property

* updates

* remove showdate prop

* updates

* update font color style

* add a funtion to get full date

* add left and right arrow in a stylesheet

* updates

* updates for calendar with memoization

* updates in calendar component

* refactor

* refactor code

* update style in header component

* changes in calendar

* add theme package

* merge with origin

* Update theme accessor to sharingapples

* resolve issue #5

* Resolve issue Unnecessary object initializations #2

* remove unused assets

* resolve issue #3 https://github.com/sharingapples/react-native-calendar/issues/3

* resolve issue #1 assets

* resolve issue #6 Make calendar a controlled component #6

* remove date if selected and pressed again

* add memoization to convert array to object

* update for typo

* showcase updates

* add remove multiple select option

* add calendar packages

* update access to calendar component

* updates for calendar packages

* updates for calendar with theme

* update index file to provide disabled value

* update readme and add readme to calendar package

* add link to package

* add a case for null prev date

* refactor code
syaau pushed a commit that referenced this issue May 17, 2019
* add DS_Store in gitignore

* add new calendar component

* update text with allowfontscaling property

* updates

* remove showdate prop

* updates

* update font color style

* add a funtion to get full date

* add left and right arrow in a stylesheet

* updates

* updates for calendar with memoization

* updates in calendar component

* refactor

* refactor code

* update style in header component

* changes in calendar

* add theme package

* merge with origin

* Update theme accessor to sharingapples

* resolve issue #5

* Resolve issue Unnecessary object initializations #2

* remove unused assets

* resolve issue #3 https://github.com/sharingapples/react-native-calendar/issues/3

* resolve issue #1 assets

* resolve issue #6 Make calendar a controlled component #6

* remove date if selected and pressed again

* add memoization to convert array to object

* update for typo

* showcase updates

* add remove multiple select option

* add calendar packages

* update access to calendar component

* updates for calendar packages

* updates for calendar with theme

* update index file to provide disabled value

* update readme and add readme to calendar package

* add link to package

* add a case for null prev date

* refactor code

* remove unused folder

* update calendar for year select

* add provision for universal screen in ios

* updates

* remove magic number

* add TouchableOpacity and comments along with new width check

* update color access in Day

* add new folder to Contain Calndar View

* update project structure

* update package name

* updates for calendar component

* quick bug fix

* updates in calendar

* remove unused props

* review updates

* style update

* review updates

* add travis

* add comment

* add wizard package

* add wizard usecase

* add spacing for footer

* form issue fix

* wizard package update

* remove style from Root View

* updates in form page

* add type prop in calendar

* remove travis

* remove unused files

* change prop value

* fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant