Underline highlighted lines in ANSI theme

sharkdp · Jan 18, 2022 · c38883c · c38883c
1 parent 9287cf6
commit c38883c
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -32,6 +32,7 @@
 - Support for `x:+delta` syntax in line ranges (e.g. `20:+10`). See  #1810 (@bojan88)
 - Add new `--acknowledgements` option that gives credit to theme and syntax definition authors. See #1971 (@Enselic)
 - Include git hash in `bat -V` and `bat --version` output if present. See #1921 (@Enselic)
+- Use underline for line highlighting on ANSI, see #1730 (@mdibaiee)
 
 ## Bugfixes
 

diff --git a/assets/syntaxes.bin b/assets/syntaxes.bin
diff --git a/assets/syntaxes/02_Extra/MediaWiki b/assets/syntaxes/02_Extra/MediaWiki
diff --git a/assets/syntaxes/02_Extra/ssh-config b/assets/syntaxes/02_Extra/ssh-config
diff --git a/src/printer.rs b/src/printer.rs
@@ -421,6 +421,10 @@ impl<'a> Printer for InteractivePrinter<'a> {
         let highlight_this_line =
             self.config.highlighted_lines.0.check(line_number) == RangeCheckResult::InRange;
 
+        if highlight_this_line && self.config.theme == "ansi" {
+            self.ansi_style.update("^[4m");
+        }
+
         let background_color = self
             .background_color_highlight
             .filter(|_| highlight_this_line);
@@ -607,6 +611,10 @@ impl<'a> Printer for InteractivePrinter<'a> {
             writeln!(handle)?;
         }
 
+        if highlight_this_line && self.config.theme == "ansi" {
+            self.ansi_style.update("^[24m");
+        }
+
         Ok(())
     }
 }