Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Rusty Object Notation (RON) #2427

Closed
kamaaina opened this issue Dec 23, 2022 · 7 comments
Closed

Add Support for Rusty Object Notation (RON) #2427

kamaaina opened this issue Dec 23, 2022 · 7 comments
Labels

Comments

@kamaaina
Copy link

Syntax:
RON - Rusty Object Notation - https://github.com/ron-rs/ron

Guideline Criteria:
https://packagecontrol.io/packages/RON

@keith-hall
Copy link
Collaborator

Forgive the silly question: I see RON is designed to be similar to Rust syntax - can we not just map RON files to the Rust syntax definition? It would be preferable to bundling another syntax, especially one that isn't super popular. Or is there something that wouldn't get highlighted correctly?

@kamaaina
Copy link
Author

yup, i too think that will work (mapping RON to rust syntax). mahalo!

@ghost
Copy link

ghost commented Apr 2, 2023

yes, this seems to work fine (see attached image). could i just fork and pr after making it do the same thing for ron as it does for rust? it seems that'd be a pretty trivial change, after all.
image

@keith-hall
Copy link
Collaborator

keith-hall commented Apr 4, 2023

yes, this seems to work fine (see attached image). could i just fork and pr after making it do the same thing for ron as it does for rust? it seems that'd be a pretty trivial change, after all. image

yes, PRs are welcome :) note that the Rust syntax definition comes from a submodule which we can't update at the moment, so your choices are to make a patch for it (i.e. similar to https://github.com/sharkdp/bat/blob/master/assets/patches/Groff.sublime-syntax.patch) or add it to https://github.com/sharkdp/bat/blob/master/src/syntax_mapping.rs.

@peppermenta
Copy link

Hi

Can I work on this?

YeungOnion added a commit to YeungOnion/bat that referenced this issue Aug 7, 2023
Add a mapping to use `Rust` for rusty object notation, identified by `.ron` extension. See [sharkdp#2427](sharkdp#2427).
Enselic pushed a commit that referenced this issue Sep 1, 2023
Add a mapping to use `Rust` for rusty object notation, identified by `.ron` extension. See [#2427](#2427).
@Horgix
Copy link

Horgix commented Sep 26, 2023

👋 Hi, I was looking into good first issues to contribute on, and I believe this one can be closed given it was solved by #2642 , doesn't it? Just figured i would notify along the way 🙂

@Enselic
Copy link
Collaborator

Enselic commented Sep 27, 2023

Indeed, thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants