Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default configuration directory on macOS to .config/bat #442

Closed
sharkdp opened this issue Dec 7, 2018 · 5 comments
Closed

Change the default configuration directory on macOS to .config/bat #442

sharkdp opened this issue Dec 7, 2018 · 5 comments
Labels
feature-request New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sharkdp
Copy link
Owner

sharkdp commented Dec 7, 2018 •
edited
Loading

Change the default path to bats configuration directory to

~/.config/bat

see #151, #375 and #419
@sharkdp sharkdp added feature-request New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 7, 2018
@lavifb
Copy link
Contributor

lavifb commented Dec 7, 2018

You seem to be using directories::ProjectDirs to get the config directory. Do you want just set it in bat or do you prefer to try to add this option to the directories crate upstream?

@sharkdp
Copy link
Owner Author

sharkdp commented Dec 7, 2018

It would be great if that would be supported by directories, yes.

However, it seemed to me that there was no intent to change this, see https://github.com/rust-lang-nursery/cli-wg/issues/7#issuecomment-391819505 and https://github.com/rust-lang-nursery/cli-wg/issues/7#issuecomment-391874453
It might be worth asking again, though.

@lavifb
Copy link
Contributor

lavifb commented Dec 7, 2018

Ok I opened an issue in directories
dirs-dev/directories-rs#47 (comment)

@lavifb
Copy link
Contributor

lavifb commented Jan 31, 2019

There does not seem to be much motion on this issue. I don't really want to write a new crate because the various dir crates seem pretty fractured already, so I'll write a quick fix in bat and hopefully this gets fixed upstream at some point.

@lavifb lavifb mentioned this issue Jan 31, 2019
Merged
@sharkdp sharkdp closed this as completed Feb 7, 2019
@sharkdp
Copy link
Owner Author

sharkdp commented Feb 8, 2019

Changes by @lavifb released in v0.10.0.

midchildan added a commit to midchildan/dotfiles that referenced this issue Feb 23, 2019
@midchildan
bat: Move configuration to ~/.config/bat
c591c0e 
See sharkdp/bat#442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lavifb @sharkdp