Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HighlightingAssets: Make .syntaxes() and .syntax_for_file_name() failable #1755

Merged

Commits on Jul 28, 2021

  1. HighlightingAssets: Make .syntaxes() and syntax_for_file_name() failable

    Or rather, introduce new versions of these methods and deprecate the old ones.
    
    This is preparation to enable robust and user-friendly support for lazy-loading.
    With lazy-loading, we don't know if the SyntaxSet is valid until after we try to
    use it, so wherever we try to use it, we need to return a Result. See discussion
    about panics in sharkdp#1747.
    Enselic committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    b6cecb5 View commit details
    Browse the repository at this point in the history