Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HighlightingAssets::get_extension_syntax(): Split up into smaller methods #1757

Merged
merged 1 commit into from
Jul 28, 2021
Merged

HighlightingAssets::get_extension_syntax(): Split up into smaller methods #1757

merged 1 commit into from
Jul 28, 2021

Conversation

Enselic
Copy link
Collaborator

@Enselic Enselic commented Jul 27, 2021

To make the code easier to understand and change.

@Enselic
HighlightingAssets::get_extension_syntax(): Split up into smaller met…
9f274f5 
…hods

To make the code easier to understand and change.
@Enselic
Copy link
Collaborator Author

Enselic commented Jul 28, 2021

For the record, this was preparation for making the method return Result (see discussion in #1755), which became way too messy in the old code.

@Enselic Enselic merged commit c0e0966 into sharkdp:master Jul 28, 2021
@Enselic Enselic deleted the split-up-get_extension_syntax branch July 28, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-hall keith-hall keith-hall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enselic @keith-hall