fix Bash completion on macOS #2074
Conversation
The Homebrew-provided bash-completion is version 1.x, which doesn't provide _init_completion. We add a standard shim instead.
|
Thank you very much for your contribution! @scop Would you mind having a short look at this? |
There was a problem hiding this comment.
Looks quite concise and ok to me, if support for such old versions is desired. Not tested as I don't have easy access to them. (An alternative would be to be more accurate that we require bash-completion >= 2, but that implies bash >= 4 and causes some extra complications for macOS users as noted in my comment about the changelog entry.)
I haven't examined the shim in depth, but based on the references it appears to be quite battle tested.
assets/completions/bat.bash.in
Outdated
| __bat_init_completion -n "=" || return 0 | ||
| fi | ||
|
|
||
| _split_longopt && split=true |
There was a problem hiding this comment.
This should go in the above __bat_init_completion block or be done within its body, it's unnecessary with bash-completion 2+ and its _init_completion.
Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
|
Thanks for taking a look @scop! I've made the suggestions you gave. Agreed this is supporting older setups, but I think it's probably relatively common amongst e.g. macOS users that haven't switched to using ZSH - a crude indicator, but |
|
Thanks! Both of you! |
|
@sharkdp are you happy for me to merge this PR, or do you follow a different process? Thanks! |
|
I am personally not well-versed enough in bash completion to make a judgement call, but I fully trust the rest of you. Merging, so that this will be included in the upcoming 0.19.1 release. |
Issue #2066 reports that bash completion is broken on macOS. This is because the version of
bash-completionthat's often packed on macOS via Home-brew is v1.3, which doesn't include the missing_init_completionfunction.This PR adopts a pattern seen across many other projects (e.g.
tmux/gh/kubectl/helm, some of which use the Cobra Go library to autogenerate their completion) to add a shim function with the minimal required functionality.Completion now works for me on both macOS 10.15.7 and Ubuntu 22.04.