Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for BusyBox less as pager #2162

Merged
merged 4 commits into from
May 4, 2022
Merged

Add support for BusyBox less as pager #2162

merged 4 commits into from
May 4, 2022

Commits on Apr 22, 2022

  1. Add support for BusyBox less as pager

    @nfisher1226
    nfisher1226 committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    030e6dd View commit details
    Browse the repository at this point in the history

  2. Run tests/syntax-tests/update.sh to update tests

    @nfisher1226
    nfisher1226 committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    40965b5 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. Address reviewer's concerns with pull request 

    * Revert all changes in `test` directory
* Minimize overall diff size
* Detect busybox from separate helper function
* Pass equivalent options to BusyBox from same code by changing from long to
  short options
    @nfisher1226
    nfisher1226 committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    384dd65 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Remove redundant if statement from previous commit 

    Add test for invalid utf-8
Add `parse_less_version_busybox` to test for invalid program
Add commenting around short options
    @nfisher1226
    nfisher1226 committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    373d413 View commit details
    Browse the repository at this point in the history