Make --no-paging/-P override --paging=... if passed as a later arg

[themkat]

Part of fix for #2128

Makes the -P and -pp option take precedence over --paging when given. See issue for more details 🙂 Had to change one test, as it assumed the opposite of what the issue is explaining.

[dufferzafar]

@themkat Why was the PR closed? Due to pending review? Or does the PR not actually solve the issue?

[themkat]

@dufferzafar It solves the issue with -P as a later argument, but not the double -pp, as I found no way of solving that. Also, I interpreted a second review never happening as a sign that the maintainers didn't want it. So I closed it for that reason alone. I was very new to Rust at the time, and was just playing around. Probably also thinking to myself that it was not good enough 🤷

[dufferzafar]

Yeah, I myself can't think of how -pp override would work with clap, but I think having -P is good as well. You should consider re-opening the PR and then asking a reviewer to have a look at it again.

[themkat]

@dufferzafar Thanks for the interest in it 😄 I have now reopened the PR.

[Enselic]

Thank you for the contribution! Sorry for letting you wait 😅

I have confirmed the test fails without the fix, and I think this is a completely reasonable little improvement, so I rebased it, updated CHANGELOG, and will merge after CI is green.

Thanks again!