Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map fish_history to YAML #2237

Merged
merged 3 commits into from
Sep 4, 2022
Merged

Map fish_history to YAML #2237

merged 3 commits into from
Sep 4, 2022

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jul 4, 2022

According to fish-shell/fish-shell#6493, fish history file fish_history is loosely based on YAML. While it is not something often inspected, it would be nice to have correct highlighting out of the box.

@@ -0,0 +1,11 @@
- cmd: echo "hello world"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to open a PR!

I'm a bit confused, because this file looks very gray and not very YAML-y. Do you see what I see or am I doing something wrong?

Screenshot 2022-08-12 at 15 30 11

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file looks fine to me.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curl -q https://raw.githubusercontent.com/sharkdp/bat/1e1fa7cde5c973ea42c97ea18479d1b0b1d3d4a0/tests/syntax-tests/highlighted/fish_history/fish_history

image

@Enselic Enselic added the waiting-on-author Progress on this PR is blocked mostly because we are waiting on the author of the PR to do something label Aug 25, 2022
@sharkdp sharkdp removed the waiting-on-author Progress on this PR is blocked mostly because we are waiting on the author of the PR to do something label Sep 4, 2022
@sharkdp sharkdp merged commit 113276a into sharkdp:master Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants