Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Manpage.sublime-syntax, Fix #2353 #2364

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Improve Manpage.sublime-syntax, Fix #2353 #2364

merged 2 commits into from
Oct 17, 2022

Conversation

Freed-Wu
Copy link
Contributor

@Freed-Wu Freed-Wu commented Oct 9, 2022 •
edited
Loading

Screenshot from 2022-10-09 13-56-09

It still exists many problems, such as man fzf

Screenshot from 2022-10-09 14-00-35

Should we highlight +x before or? Case-XXX shouldn't be highlighted, right?

Screenshot from 2022-10-09 14-01-43

Wrong N[,...].

How to distinguish the following -.s?

Screenshot from 2022-10-09 14-02-42
Screenshot from 2022-10-09 14-03-12

@keith-hall
Copy link
Collaborator

It would be great to add some "highlighted file" tests for this. Basically just putting man fzf into a file in https://github.com/sharkdp/bat/tree/master/tests/syntax-tests/source/Manpage and running https://github.com/sharkdp/bat/blob/master/tests/syntax-tests/update.sh afterwards and including both files in the PR. This will enable us to see how future changes affect the highlighting, to help prevent regressions.

@Freed-Wu
Copy link
Contributor Author

It would be great to add some "highlighted file" tests.

Done.

keith-hall
keith-hall approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@keith-hall keith-hall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You can also optionally update the changelog so others will know what you fixed :)

@Freed-Wu
Copy link
Contributor Author

update the changelog

Fixed.

@Enselic Enselic merged commit f215d07 into sharkdp:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-hall keith-hall keith-hall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Freed-Wu @keith-hall @Enselic