Eliminate dependency on serde's "derive" feature #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft until the next |
|
Awesome, thanks. I'll try to get a syntect release out relatively soon. |
|
(https://crates.io/crates/syntect/5.2.0 has been released now.) |
|
Since then, #2755 added a new unconditional dependency on |
jonasbb
added a commit
to jonasbb/serde_with
that referenced
this pull request
Feb 8, 2024
This allows serde, and other crates downstream of it like serde_json, to compile in parallel with serde_derive. Without this PR, in any dependency graph that pulls in serde_with, first serde_derive would need to compile, then serde would need to compile, then serde_json would need to compile. sharkdp/bat#2815 has a diagram of the impact of this change.
|
Looks like this has been fixed — thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in trishume/syntect#511 and niklasmohrin/clircle#12 to improve bat compile time by 20%. (
batis on the critical path forcargo-expand's build, so I am interested in this PR because it will speed upcargo-expandcompilation by the same amount.)cargo build --lib --timings: