Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ansi_colours package for better true-colour approximation #319

Merged
merged 1 commit into from
Sep 23, 2018

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Sep 21, 2018

No description provided.

@gjnoonan
Copy link

👍 LGTM

@sharkdp
Copy link
Owner

sharkdp commented Sep 23, 2018

Fantastic, thank you very much!

I'm curious: why did you choose to implement the core functionality in C instead of Rust?

@sharkdp sharkdp merged commit 79b960e into sharkdp:master Sep 23, 2018
@mina86
Copy link
Contributor Author

mina86 commented Sep 23, 2018

I figured if I want to use the same code in C it’s easier to have it implemented in C than having to create C bindings for Rust code. Machines which have Rust compiler are most likely also equipped with C compiler where the reverse isn’t necessarily true. And the code is just bunch of arithmetic operations, not a lot of pointer arithmetic or memory allocation, so I figured added safety of Rust isn’t critical.

@sharkdp
Copy link
Owner

sharkdp commented Sep 23, 2018

Thank you, that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants