fix: localtime error #113
Merged
fix: localtime error #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sharkdp，check it pls |
|
I'm not sure this is the correct way to fix this problem (silencing the warning). How about applying an actual fix (switch to |
|
I will try it |
|
@sharkdp, i use localtime_s to fix error, pls check it. |
sharkdp
reviewed
Jul 7, 2021
dbg.h
Outdated
| @@ -550,7 +550,12 @@ inline bool pretty_print(std::ostream& stream, const time&) { | |||
| const auto us = | |||
| duration_cast<microseconds>(now.time_since_epoch()).count() % 1000000; | |||
| const auto hms = system_clock::to_time_t(now); | |||
| #if _MSC_VER >= 1600 | |||
| const auto tm = new std::tm; | |||
There was a problem hiding this comment.
This allocates a new tm object on the heap and never releases the memory.
sharkdp
reviewed
Jul 7, 2021
sharkdp
reviewed
Jul 8, 2021
dbg.h
Outdated
| stream << "current time = " << std::put_time(tm, "%H:%M:%S") << '.' | ||
| << std::setw(6) << std::setfill('0') << us; | ||
|
|
||
| delete tm; |
There was a problem hiding this comment.
Now you are calling delete on a tm* pointer to a static tm object inside std::localtime when the #else branch is active (leading to the CI crashes on non-windows environments). Please don't use new/delete at all here but rather simply "stack-allocate" a tm object locally.
|
Thank you very much! |
It's my pleasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when environment is win10 and vs2019
i encountered this problem
And add this macro can solve it.