Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Incorrect typename for multidimensional c-style arrays #129

Merged
merged 2 commits into from
Jan 17, 2023
Merged

[Bugfix] Incorrect typename for multidimensional c-style arrays #129

merged 2 commits into from
Jan 17, 2023

Conversation

winwinashwin
Copy link
Contributor

Fixes a bug introduced in cf4ad54 which caused dimensions of multidimensional arrays to be formatted in reverse order.

Buggy output

int a[1][2][3];
dbg(a);  // ... (int32_t [3] [2] [1])

Have extended tests for C-style arrays

sharkdp
sharkdp reviewed Jan 17, 2023
View reviewed changes
tests/basic.cpp Outdated Show resolved Hide resolved
sharkdp
sharkdp approved these changes Jan 17, 2023
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Just one minor question

@sharkdp sharkdp merged commit 9c5a5a3 into sharkdp:master Jan 17, 2023
@sharkdp
Copy link
Owner

sharkdp commented Jan 17, 2023

Thank you. Great work (Implementation, Tests, …)

@winwinashwin winwinashwin deleted the fix/typename-multidim-array branch January 18, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winwinashwin @sharkdp