regression: fix permissions, results directory creation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
reviewed
Oct 10, 2019
regression.sh
Outdated
|
|
||
| rm -f regression-results/*.md | ||
| mkdir -p "$RESULT_DIR" | ||
| rm -f $RESULT_DIR/*.md |
There was a problem hiding this comment.
I always get a little bit nervous when I see rm with unquoted variables. Just to be safe (if someone changes RESULTS_DIR to my folder, for example), we should quote it:
rm -f "$RESULTS_DIR"/*.mdThere was a problem hiding this comment.
Fair enough - I actually wasn't aware you could partially quote a bash expansion, so 👍 to learning things
|
Thank you very much for this! |
tommilligan
force-pushed
the
fix-regression-script
branch
from
3183f56 to
6da7a63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and comments that will be useful to other new users.
Found testing sharkdp/fd#497