Add windows compatibility

[sebasv]

This code is cross-platform save for the "executable file" check, which is only relevant on unix systems, and is done for the sole purpose of color-coding output lines.

I managed to make your code run on windows by adding conditional compilation operators to
use std::os::unix::fs::PermissionsExt; and to redefine the is_executable function on non-Linux systems.

[sharkdp]

Thank you for trying this. I'll try to implement this as soon as I get access to a Windows system.

[sebasv]

I'd be happy to create a pull request!

[sharkdp]

That would be great, thank you.

[sharkdp]

Apart from the current compilation problems, colored output does not work on Windows (no support for ANSI sequences). We could consider using termcolor.

[sebasv]

PR #35 concerns windows compatibility.
Powershell does work with colored output. To be honest I haven't touched cmd since the inception of Powershell, but the termcolor crate looks like a nice feature for the hardcore cmd users!

[sharkdp]

Oh, I didn't know that, that's cool! I just quickly tried cmd today.. thanks!

[sharkdp]

Closed via #35

[jmcomets]

I'm surprised this was closed considering colored output does not work in cmd.exe, I'm getting ansi escapes printed to the console every time I fire up fd and have to add the --no-color option each time. Maybe we should re-open this/add an issue on Windows coloring? termcolor crate sounded like a great option.

[sebasv]

This issue was regarding compatibility; The code simply didn't compile on windows. Having to flag no-color should be the default behavior imho since this is a shortcoming of cmd, not Windows. If you want colored output, try Powershell. It's like bash and Python had a baby in Microsoft country. (And it's developed by MSFT)

[jmcomets]

I disagree, we have colored output in CMD via the various `color` calls. Surely if `ripgrep` can do it, `fd` can do it.

…

On 18:51, Thu, Jul 20, 2017 Sebastiaan Vermeulen ***@***.***> wrote: This issue was regarding compatibility; The code simply didn't compile on windows. Having to flag no-color should be the default behavior imho since this is a shortcoming of cmd, not Windows. If you want colored output, try Powershell. It's like bash and Python had a baby in Microsoft country. (And it's developed by MSFT) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#29 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABzmgxuSiQ4Iv3F9GVITqj2ajlEpOJ_pks5sP4WbgaJpZM4NyNMj> .

[sebasv]

Then by all means, start a pull request to add cmd support. I'm just saying that cmd support is not the same as windows compatibility, and should be opened as another issue.

[jmcomets]

I looked into it a bit today, there's a few issues in order to implement it:

• cmd has no support for "italic" or "underlined" text, in which case these options should be ignored
• after checking out termcolor, I see no support for fixed colors. There seems to be work in progress here

[sharkdp]

@jmcomets Cool, thanks for looking into this! I also think we should open a new issue for this.