Fix panic when using --owner #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
force-pushed
the
owner-without-panic
branch
from
ae85cb8 to
e4edf87
Compare
Unfortunately, clap_derive can't combine a value_parser of Option<T> with an optional argument to get a merged Option<T> so we need to do the check for the nop outside of the value parser. Also adds some tests for --owner Fixes: sharkdp#1163
tmccombs
force-pushed
the
owner-without-panic
branch
from
e4edf87 to
c159ea2
Compare
Because macos doesn't have a "root" user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, clap_derive can't combine a value_parser of Option with an optional argument to get a merged Option so we need to do the check for the nop outside of the value parser.
Also adds some tests for --owner
Fixes: #1163