Refactor scan() #1413
Merged
Refactor scan() #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
approved these changes
Oct 31, 2023
sharkdp
reviewed
Nov 1, 2023
sharkdp
approved these changes
Nov 1, 2023
tavianator
force-pushed
the
worker-state
branch
from
ed6396d to
77f68d3
Compare
tavianator
force-pushed
the
worker-state
branch
from
77f68d3 to
70126ca
Compare
tavianator
changed the title
tavianator
force-pushed
the
worker-state
branch
from
70126ca to
927ad0c
Compare
tmccombs
reviewed
Nov 4, 2023
| // Spawn the sender threads. | ||
| self.spawn_senders(walker, tx); | ||
|
|
||
| receiver.join().unwrap() |
There was a problem hiding this comment.
instead of spawning a separate thread and joining on it here, could we just call self.receive(rx) here?
There was a problem hiding this comment.
I tried that originally but the problem is spawn_senders() is blocking. So we need an extra background thread either for receive() or spawn_senders().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.