Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1085 for real #1549

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

tavianator
Copy link
Collaborator

cross doesn't pass all environment variables through into the build
container, so JEMALLOC_SYS_WITH_LG_PAGE=16 wasn't being picked up from
the host. Instead, set it explicitly in Cross.toml.

Link: https://github.com/cross-rs/cross/wiki/Configuration

@tavianator
Copy link
Collaborator Author

@mathomp4 Do you mind testing the aarch64 artifacts from this PR, so we can see if we actually fixed it this time? https://github.com/sharkdp/fd/actions/runs/8971773406

@mathomp4
Copy link

mathomp4 commented May 6, 2024

@mathomp4 Do you mind testing the aarch64 artifacts from this PR, so we can see if we actually fixed it this time? sharkdp/fd/actions/runs/8971773406

The answer is yes and no. For the GNU build it works:

$ /home/mthompso/fd-testing/fd-v10.0.0-aarch64-unknown-linux-gnu/fd -e lua --max-results 3
GitProjects/z.lua/
modulefiles/GCC12Env.lua
modulefiles/GCC13Env.lua

Huzzah!

But the MUSL build doesn't:

$ /home/mthompso/fd-testing/fd-v10.0.0-aarch64-unknown-linux-musl/fd -e lua --max-results 3
<jemalloc>: Unsupported system page size
<jemalloc>: Unsupported system page size
memory allocation of 5 bytes failed
Aborted (core dumped)

cross doesn't pass all environment variables through into the build
container, so JEMALLOC_SYS_WITH_LG_PAGE=16 wasn't being picked up from
the host.  Instead, set it explicitly in Cross.toml.

Link: https://github.com/cross-rs/cross/wiki/Configuration
@tavianator
Copy link
Collaborator Author

@mathomp4 Well that's just because I forgot we even use jemalloc with musl. (We disable it for 32-bit musl builds, I forgot about the 32-bit part.)

Can you try https://github.com/sharkdp/fd/actions/runs/8972442583 once it finishes? Thanks again :)

@mathomp4
Copy link

mathomp4 commented May 6, 2024

@mathomp4 Well that's just because I forgot we even use jemalloc with musl. (We disable it for 32-bit musl builds, I forgot about the 32-bit part.)

Can you try sharkdp/fd/actions/runs/8972442583 once it finishes? Thanks again :)

Things look good!

$ /home/mthompso/fd-testing/fd-v10.0.0-aarch64-unknown-linux-gnu/fd -e lua --max-results 3
modulefiles/GCC12Env.lua
modulefiles/GCC13Env.lua
modulefiles/cmake/3.29.2.lua
mthompso@gg1 ~
$ /home/mthompso/fd-testing/fd-v10.0.0-aarch64-unknown-linux-musl/fd -e lua --max-results 3
modulefiles/GCC12Env.lua
modulefiles/GCC13Env.lua
modulefiles/cmake/3.29.2.lua

thanks!

@tavianator tavianator merged commit 0e4488e into sharkdp:master May 6, 2024
17 checks passed
@tavianator tavianator deleted the jemalloc-aarch64 branch May 6, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants