Some cleanup and refactor #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a split commit, refraining from renaming too much. The drop(tx) call is no longer necessary, as the first sender is dropped at the end of spawn_senders(..)
|
It looks like the Travis checks are failing due to setup issues, not the PR per se. |
sharkdp
reviewed
Jan 26, 2019
|
|
||
| // Drop the initial sender. If we don't do this, the receiver will block even | ||
| // if all threads have finished, since there is still one sender around. | ||
| drop(tx); |
There was a problem hiding this comment.
If I understand this correctly, calling drop explicitly is not needed anymore because tx is moved into the spawn_senders function and dropped at the end of the function scope?
There was a problem hiding this comment.
That is correct. It's explained in the commit message of a05312e
There was a problem hiding this comment.
Ah, perfect! I missed that, sorry.
|
Awesome work, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a complete form, but this beings some cleanup and function splitting mentioned in #382
This is not a very focused set of changes, just picking some low hanging refactoring fruit.