Split executable and empty file "types" into seperate "prop" flag #847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But keep the old file types for backwards compatibility.
Fixes #823
This is a work in progress. I haven't added anything to the changelog yet, and the documentation could probably be a little better. I'm also not entirely sure if this is something we want to do.
Note that the new
--prop
options behave slightly differently than the old file types. In particular:--type
option is given, thenempty
defaults to just empty files, not files and directories. That makes it more consistent with the wayexecutable
works, seems more useful to me, and is simpler to implement, but I could be convinced to change this to default to files and directories.executables
property no longer always includesfiles
, so you can search for just executable directories. I'm not really sure when that would be useful, but it seems more consistent and logical to me.