Include valid symlinks with both --follow and --type symlink #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes it so that if you specify `--type symlink` then it will check if each entry is a symlink even if we would otherwise follow it. Fixes: sharkdp#939
tmccombs
commented
Jan 10, 2022
| (!self.files && entry_type.is_file()) | ||
| || (!self.directories && entry_type.is_dir()) | ||
| || (!self.symlinks && entry_type.is_symlink()) | ||
| (!self.files && entry_type.is_file() && !is_symlink) |
There was a problem hiding this comment.
It might be better for this (and the following line) to be something like:
Suggested change
| (!self.files && entry_type.is_file() && !is_symlink) | |
| (!self.files && entry_type.is_file() && !(self.symlinks && is_symlink)) |
(maybe factoring that out self.symlinks && is_symlink into a variable?)
so that if you specify only --type file it doesn't include symlinks to directories and vice versa.
|
I'm not sure we should change behaviour here. RIght now |
|
I also think we should stick with the current behavior and maintain compatibility to |
|
I'm ok with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes it so that if you specify
--type symlinkthen it willcheck if each entry is a symlink even if we would otherwise follow it.
Fixes: #939