Squeeze identical lines #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! Some tests are currently failing.. |
|
Looks like the issues are on 32-bit systems. I'll investigate. |
|
Note: there is also #218 |
GrigorenkoPV
suggested changes
Sep 8, 2024
| @@ -281,7 +281,8 @@ pub struct Printer<'a, Writer: Write> { | |||
| display_offset: u64, | |||
| /// The number of panels to draw. | |||
| panels: u64, | |||
| squeeze_byte: usize, | |||
| squeeze_byte: Option<usize>, | |||
There was a problem hiding this comment.
Changing this (as well as some other code below) from usize to u64 fixes the tests on 32-bit platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186.
This brings the squeezing feature to parity with
hexdump. Lines that contain identical data should be squeezed, not just when they are all filled with a single byte.