This repository has been archived by the owner on Sep 18, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, the
.ifCached
method uses the same callback method as the.then
method.Right now nothing happens when
useLegacyPromiseExtensions
is set to false, the application will just throw a general error saying the.cached
function does not exist for the method (when it is used). I noticed in the angular code itself they throw the legacy errors like this:(https://github.com/angular/angular.js/blob/v1.5.x/src/ng/http.js#L12)
Which they invoke using:
(https://github.com/angular/angular.js/blob/v1.5.x/src/ng/http.js#L1006)
I will try and see if it's possible to import this method, but it doesn't seem like it. If not, do you think it's worth making it the same kind of error, or should a generic thrown error be sufficient?