Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate lodash #30

Merged
merged 2 commits into from
Jul 25, 2020
Merged

Eliminate lodash #30

merged 2 commits into from
Jul 25, 2020

Conversation

shawnmcknight
Copy link
Owner

Description 📝

After being prodded by @kthompson23, this PR eliminates lodash as a dependency and adds an internalized debounce function.

Type of change 💎

  • Refactor

How Has This Been Tested? 🚦

  • Existing unit tests continue to pass
  • New unit tests added for debounce function
  • Ran example and confirmed functionality is still working as desired
  • Added console.log statements during debounce testing to ensure firing at the appropriate times

Checklist 🏁

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • My changes pass lint, prettier, and TS checks
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas

@shawnmcknight shawnmcknight merged commit f06de45 into master Jul 25, 2020
@shawnmcknight shawnmcknight deleted the eliminate-lodash branch July 25, 2020 19:40
@kgregory
Copy link
Collaborator

Is there a zero deps award?

@shawnmcknight
Copy link
Owner Author

Is there a zero deps award?

I think this is about as good as it gets:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants