INSERT's are failing for long table names 115

lib/pg_online_schema_change/orchestrate.rb

@@ -35,7 +35,6 @@ def setup_store
         Store.set(:operation_type_column, "operation_type_#{pgosc_identifier}")
         Store.set(:trigger_time_column, "trigger_time_#{pgosc_identifier}")
         Store.set(:audit_table_pk, "at_#{pgosc_identifier}_id")
-        Store.set(:audit_table_pk_sequence, "#{audit_table}_#{audit_table_pk}_seq")
         Store.set(:shadow_table, "pgosc_st_#{client.table.downcase}_#{pgosc_identifier}")
         Store.set(:primary_table_storage_parameters, Query.storage_parameters_for(client, client.table_name, true) || "")
 
@@ -109,6 +108,8 @@ def setup_audit_table!
         SQL
 
         Query.run(client.connection, sql)
+
+        Store.set(:audit_table_pk_sequence, Query.get_sequence_name(client, audit_table, audit_table_pk))
       end
 
       def setup_trigger!

lib/pg_online_schema_change/query.rb

@@ -134,6 +134,18 @@ def get_indexes_for(client, table)
         indexes
       end
 
+      # fetches the sequence name of a table and column combination
+      def get_sequence_name(client, table, column)
+        query = <<~SQL
+          SELECT pg_get_serial_sequence('#{table}', '#{column}');
+        SQL
+
+        run(client.connection, query) { |result| result.map { |row|
+          row["pg_get_serial_sequence"]
+        }
+        }.first
+      end
+
       def get_triggers_for(client, table)
         query = <<~SQL
           SELECT pg_get_triggerdef(oid) as tdef FROM pg_trigger

spec/lib/orchestrate_spec.rb

@@ -180,6 +180,29 @@
         assertions: [{ count: 1, data: [{ "reloptions" => "{autovacuum_enabled=false}" }] }],
       )
     end
+
+    describe "when table has a long name" do
+      let(:client) do
+        options =
+          client_options.to_h.merge(alter_statement: "ALTER TABLE this_is_a_table_with_a_very_long_name ADD COLUMN \"user_id\" int;")
+        client_options = Struct.new(*options.keys).new(*options.values)
+        PgOnlineSchemaChange::Client.new(client_options)
+      end
+
+      before do
+        allow(PgOnlineSchemaChange::Client).to receive(:new).and_return(client)
+        described_class.setup!(client_options)
+        setup_tables(client)
+      end
+
+      it "successfully" do
+        described_class.setup_audit_table!
+
+        sequence_name = PgOnlineSchemaChange::Query.get_sequence_name(client, described_class.audit_table, described_class.audit_table_pk)
+        expect(described_class.audit_table_pk_sequence).to eq(sequence_name)
+      end
+    end
+
   end
 
   describe ".setup_trigger!" do

spec/lib/query_spec.rb

@@ -321,6 +321,14 @@
           "constraint_validated" => "t",
           "definition" => "FOREIGN KEY (book_id) REFERENCES books(user_id)",
         },
+        {
+          "table_on" => "this_is_a_table_with_a_very_long_name",
+          "table_from" => "-",
+          "constraint_type" => "p",
+          "constraint_name" => "this_is_a_table_with_a_very_long_name_pkey",
+          "constraint_validated" => "t",
+          "definition" => "PRIMARY KEY (id)",
+        },
       ]
 
       expect(described_class.get_all_constraints_for(client)).to eq(result)

spec/support/database_helpers.rb

@@ -80,6 +80,11 @@ def new_dummy_table_sql
         "createdOn" TIMESTAMP NOT NULL,
         last_login TIMESTAMP
       );
+
+      CREATE TABLE IF NOT EXISTS #{schema}.this_is_a_table_with_a_very_long_name (
+        id serial PRIMARY KEY,
+        "createdOn" TIMESTAMP NOT NULL
+      );
 
       ALTER ROLE jamesbond SET statement_timeout = '60s';
       ALTER ROLE jamesbond SET lock_timeout = '60s';