Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniquely identify trigger_time column #51

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

shayonj
Copy link
Owner

@shayonj shayonj commented Feb 22, 2022

This attaches the identifier on the column name
and that way we can ensure the column is not generic
enough so much so that it may conflict with column
names of primary table.

Also updates the column name to be more easy to
read.

Similar to: #50

This attaches the identifier on the column name
and that way we can ensure the column is not generic
enough so much so that it may coflict with column
names of primary table
@shayonj shayonj requested a review from jfrost February 22, 2022 14:01
Copy link
Collaborator

@jfrost jfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shayonj shayonj merged commit 154c591 into main Feb 22, 2022
@shayonj shayonj deleted the s/trigger-time-column branch February 22, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants