Fix tables check in config_check (#93)

* Perform config check in CI

* Add defaults to cli options

* Remove config check from start

* Ensure boostrap asserts in CI

lib/pg_easy_replicate/cli.rb

@@ -18,6 +18,7 @@ class CLI < Thor
                   desc: "Copy schema to the new database"
     method_option :tables,
                   aliases: "-t",
+                  default: "",
                   desc:
                     "Comma separated list of table names. Default: All tables"
     method_option :schema_name,
@@ -87,6 +88,7 @@ def cleanup
                     "Name of the schema tables are in, only required if passing list of tables"
     method_option :tables,
                   aliases: "-t",
+                  default: "",
                   desc:
                     "Comma separated list of table names. Default: All tables"
     method_option :recreate_indices_post_copy,

scripts/e2e-start.sh

@@ -10,7 +10,7 @@ export SOURCE_DB_URL="postgres://james-bond:james-bond123%407%21%273aaR@localhos
 export TARGET_DB_URL="postgres://james-bond:james-bond123%407%21%273aaR@localhost:5433/postgres-db"
 export PGPASSWORD='james-bond123@7!'"'"''"'"'3aaR'
 
-# Bootstrap and cleanup
+# Config check, Bootstrap and cleanup
 echo "===== Performing Bootstrap and cleanup"
 bundle exec bin/pg_easy_replicate bootstrap -g cluster-1 --copy-schema
 bundle exec bin/pg_easy_replicate start_sync -g cluster-1 -s public --recreate-indices-post-copy

spec/smoke_spec.rb

@@ -4,7 +4,8 @@
   describe "dataset" do
     it "matches after switchover" do
       # Bootstrap
-      `./scripts/e2e-bootstrap.sh`
+      system("./scripts/e2e-bootstrap.sh")
+      expect($CHILD_STATUS.success?).to be(true)
 
       r =
         PgEasyReplicate::Query.run(