Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use aws-sdk-js-v3 which is more compact than v2 #103

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Use aws-sdk-js-v3 which is more compact than v2 #103

merged 1 commit into from
Aug 18, 2021

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Aug 17, 2021

Closes #94

@exoego exoego marked this pull request as ready for review August 17, 2021 13:34
@exoego
Copy link
Contributor Author

exoego commented Aug 17, 2021

Hmm, tests fail on my local due to connection error.
If setup.js and teardown.js are reverted, tests run successfully... 🤔

@vladholubiev
Copy link
Member

Wow, thanks for the PR! I'll take a look at it.

@vladholubiev vladholubiev mentioned this pull request Aug 18, 2021
Merged
@vladholubiev vladholubiev merged commit 6f1f45b into shelfio:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for aws-sdk v3
2 participants
@exoego @vladholubiev