update teardown to only delete newly created test tables #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor getConfig and deleteTables to new utils - add getRelevantTables util - refactor setup to use new utils - update setup and teardown to only attempt deletion of tables created by setup
|
@vladgolubev you look like an active maintainer - Is any interest in this change? |
|
@dustinsgoodman yeap, interested, let me review! thanks for pinging me, somehow I missed the original notification |
vladholubiev
approved these changes
Feb 6, 2023
|
Amazing! Thanks so much @vladgolubev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#95 highlights a problem with using this library. If you are using the
sharedDbflag on a dynamodb-local instance, it clears the entire database as part of teardown. In my case, I was using stages to separate database tables by environment but the teardown here is indiscriminate and deletes everything. As a developer writing tests, I only want this tool to delete the tables it creates and leave other deletion to the implementor to decide as described in the discussion of #55. This PR makes the following changes:Closes #95