Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fidget filetype to exclude_filetypes #133

Closed
wants to merge 1 commit into from

Conversation

warbacon
Copy link
Contributor

fidget.nvim is a popular Neovim plugin that describes itself as an "Extensible UI for Neovim notifications and LSP progress messages". The indent guides in its UI appear to be rendering, as shown in this image:

image

To address this, I added its filetype to the exclude_filetype table and enabled the exclusion by default, as this seems to be an error and could potentially harm performance.

@warbacon warbacon closed this Sep 23, 2024
@warbacon
Copy link
Contributor Author

Anyway, I have decided to stop using this plugin...

@shellRaining
Copy link
Owner

Sorry, due to my internship, I really don't have much energy to focus on this project. I may pick it up again later, but right now the maintenance pressure is indeed quite high

There is also an issue with the language. I mainly write JavaScript and TypeScript, which have more mature toolchains compared to Lua, making them relatively easier to maintain. Perhaps my programming skills have reached a plateau, as maintaining the current thousands of lines of code is proving to be quite challenging.

@warbacon
Copy link
Contributor Author

Don't worry man, your plugin is awesome, I just switched back to indent-blankline because almost all colorschemes support it and I like the way the indent highlighting looks better in contrast to the chunk. Add to that I'm not sure if I'm going to run into a problem in the future because the chunk selection seems very complex and language dependent. But as I said, it's still pretty awesome and it's more than I know how to do at the moment.

And a question if you know the answer, do you know if this plugin is significantly faster than indent-blankline?

@shellRaining
Copy link
Owner

From my own tests, it is like this, but I did occasionally encounter stuttering during use. as mentioned earlier, I currently do not have the energy to find the root cause of the issue. If you are interested, you can try to find some files to compare and test.

@shellRaining
Copy link
Owner

Now based on buftype to determine whether to render, possibly solving this issue.

@warbacon
Copy link
Contributor Author

warbacon commented Oct 1, 2024

Can confirm, it's fixed now 😁.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants