Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for ls for a single file #784

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Add a test for ls for a single file #784

merged 1 commit into from
Oct 18, 2017

Conversation

freitagbr
Copy link
Contributor

Fixes #732

Adds a single test to test/ls.js that runs ls on a single file, which is not covered by the existing tests.

@codecov-io
Copy link

codecov-io commented Oct 13, 2017

Codecov Report

Merging #784 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #784   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          33       33           
  Lines        1239     1239           
=======================================
  Hits         1182     1182           
  Misses         57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea0e58...d268563. Read the comment docs.

Copy link
Member

@nfischer nfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't change coverage? Maybe the lines were covered by some other test?

@freitagbr
Copy link
Contributor Author

freitagbr commented Oct 13, 2017

All of the code paths were probably covered by the other tests, but not in the combination that the new test does. It's good having this test around because it tests a common use case for ls.

@nfischer nfischer merged commit 7cbce88 into master Oct 18, 2017
@nfischer nfischer deleted the add-ls-file-test branch July 4, 2018 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants