wip

README.md

@@ -111,9 +111,9 @@ Modify files details before the manifest is created. [more details](#hooks-optio
 ### `sort`
 
 Type: `function`<br>
-Default: alphebetical
+Default: in dependency order
 
-Sort files before they are passed to reduce.  (unsorted array is in order of dependency graph) [more details](#hooks-options)
+Sort files before they are passed to reduce. [more details](#hooks-options)
 
 ### `reduce`
 

lib/plugin.js

@@ -68,6 +68,7 @@ ManifestPlugin.prototype.apply = function(compiler) {
         });
       }
     });
+
     // We now perform a topological sorting on the input chunks and built edges
     var chunks = toposort.array(compilation.chunks, edges);
 
@@ -146,19 +147,6 @@ ManifestPlugin.prototype.apply = function(compiler) {
 
     if (this.opts.sort) {
       files = files.sort(this.opts.sort);
-    } else {
-      files = files.sort(function (fileA, fileB) {
-        var a = fileA.name;
-        var b = fileB.name;
-
-        if (a < b) {
-          return -1;
-        } else if (a > b) {
-          return 1;
-        } else {
-          return 0;
-        }
-      });
     }
 
     var manifest;

spec/fixtures/common.js

@@ -0,0 +1 @@
+module.exports = {};

spec/fixtures/main.js

@@ -0,0 +1,2 @@
+require('./common.js');
+console.log('main');

spec/fixtures/util.js

@@ -0,0 +1,2 @@
+require('./common.js');
+console.log('util');

spec/plugin.spec.js

@@ -90,6 +90,32 @@ describe('ManifestPlugin', function() {
       });
     });
 
+    it('multiple file output is dependency ordered', function(done) {
+      webpackCompile({
+        context: __dirname,
+        entry: {
+          main: './fixtures/main.js',
+          vendor: './fixtures/util.js'
+        },
+        plugins: [
+          new plugin({
+            seed: [],
+            reduce: function (manifest, file) {
+              return manifest.concat(file.name);
+            }
+          }),
+          new webpack.optimize.CommonsChunkPlugin({
+            name: 'common',
+            filename: 'common.js'
+          })
+        ]
+      }, {}, function(manifest) {
+        expect(manifest).toEqual(['common.js', 'vendor.js', 'main.js']);
+
+        done();
+      });
+    });
+
     it('works with hashes in the filename', function(done) {
       webpackCompile({
         context: __dirname,
@@ -581,6 +607,35 @@ describe('ManifestPlugin', function() {
     });
   });
 
+  describe('sort', function() {
+    it('should allow ordering of output', function(done) {
+      webpackCompile({
+        context: __dirname,
+        entry: {
+          one: './fixtures/file.js',
+          two: './fixtures/file-two.js'
+        },
+        output: {
+          filename: '[name].js'
+        }
+      }, {
+        manifestOptions: {
+          seed: [],
+          sort: function(file, i) {
+            return 1;
+          },
+          reduce: function (manifest, file) {
+            return manifest.concat(file.name);
+          }
+        }
+      }, function(manifest, stats) {
+        expect(manifest).toEqual(['two.js', 'one.js']);
+
+        done();
+      });
+    });
+  });
+
   describe('reduce', function() {
     it('should generate custom manifest', function(done) {
       webpackCompile({