Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an entryNameKeys option #113

Closed
wants to merge 3 commits into from

Conversation

jacobwindsor
Copy link

Addresses #110

@codecov-io
Copy link

codecov-io commented Jan 8, 2018

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #113   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          78     78           
=====================================
  Hits           78     78
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409b0fb...ea6a382. Read the comment docs.

@jacobwindsor
Copy link
Author

jacobwindsor commented Jan 8, 2018

In the previous commit I have simply excluded sourcemaps from having their extension excluded. I realised that after excluding the extension, each key in the manifest would point to the sourcemap file and not the source since the former is processed after.

I don't think this is the best way to go. Instead, I would prefer something like:

{
   entryName: {
    source: 'main.js'
    sourceMap: 'main.js.map'
  }
}

However, that's a fairly large change and might warrant another PR entirely.

@shellscape
Copy link
Owner

@jacobwindsor Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. We've landed a major refactor in #222 that has resulted in some significant conflicts. Would you be interested in reworking your PR on top of the new codebase?

@shellscape
Copy link
Owner

Closed by a998c4b

@shellscape shellscape closed this Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants