Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add outputFormatter option #123

Merged
merged 2 commits into from
Feb 26, 2018
Merged

add outputFormatter option #123

merged 2 commits into from
Feb 26, 2018

Conversation

Ficik
Copy link
Contributor

@Ficik Ficik commented Feb 21, 2018

Support different manifest output formats.

In my case I need to generate manifest as yaml to load it as symfony config. With this I can replace JSON.stringify with YAML.stringify in my webpack configuration.

@codecov-io
Copy link

codecov-io commented Feb 21, 2018

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #123   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          78     79    +1     
=====================================
+ Hits           78     79    +1
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409b0fb...7635d5d. Read the comment docs.

@mastilver
Copy link
Contributor

Thank you for that! :)

I kind of prefer serialize options from #122

@Ficik
Copy link
Contributor Author

Ficik commented Feb 21, 2018

Sure, serialize sounds better. Renamed to serialize.

@mastilver mastilver merged commit 661af13 into shellscape:master Feb 26, 2018
@mastilver
Copy link
Contributor

Thank you @Ficik for your work 👍

@mastilver
Copy link
Contributor

published on v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants