Merge pull request #34 from shenril/refactor/fix-codacy-issues

Fix codacy issues on linting

lib/modules/attacks/bruteforce/admin.py

@@ -1,6 +1,5 @@
 from urllib.parse import urljoin
 from concurrent.futures import ThreadPoolExecutor, as_completed
-from lib.config.settings import Risk
 from lib.utils.container import Services
 from .. import AttackPlugin
 

lib/modules/attacks/other/robots.py

@@ -1,4 +1,3 @@
-import re
 from urllib.parse import urljoin
 
 from lib.utils.container import Services

lib/request/requestfactory.py

@@ -16,11 +16,14 @@ class RequestFactory:
     def __init__(self):
         pass
 
-    def make_multiple_requests(self, **kwargs):
+    @classmethod
+    def make_multiple_requests(cls, **kwargs):
         return MultipleHTTPRequests(**kwargs)
 
-    def make_single_request(self, **kwargs):
+    @classmethod
+    def make_single_request(cls, **kwargs):
         return SingleHTTPRequest(**kwargs)
 
-    def make_dns_request(self, **kwargs):
+    @classmethod
+    def make_dns_request(cls, **kwargs):
         return DNSRequest(**kwargs)

lib/utils/output.py

@@ -14,25 +14,25 @@ def __init__(self, level=0):
 
     def finding(self, value):
         print(
-            "{}[+]{} {}{}{}".format(Output.g, Output.e, Output.w, value, Output.e),
+            "{}[+]{} {}{}{}".format(self.g, self.e, self.w, value, self.e),
             flush=True,
         )
 
     def error(self, value):
         print(
-            "{}[-]{} {}{}{}".format(Output.r, Output.e, Output.w, value, Output.e),
+            "{}[-]{} {}{}{}".format(self.r, self.e, self.w, value, self.e),
             flush=True,
         )
 
     def info(self, value):
         print(
-            "{}[i]{} {}{}{}".format(Output.y, Output.e, Output.w, value, Output.e),
+            "{}[i]{} {}{}{}".format(self.y, self.e, self.w, value, self.e),
             flush=True,
         )
 
     def debug(self, value):
         if self.level == 1:
             print(
-                "{}[d]{} {}{}{}".format(Output.c, Output.e, Output.w, value, Output.e),
+                "{}[d]{} {}{}{}".format(self.c, self.e, self.w, value, self.e),
                 flush=True,
             )

tests/lib/config/test_config.py

@@ -40,4 +40,4 @@ def test_yaml_config_file():
     if settings.plugins[0] != "test-plugin":
         raise AssertionError
     with pytest.raises(IndexError):
-        settings.plugins[1]
+        dir(settings.plugins[1])

tests/lib/modules/fingerprints/test_fingerprint.py

@@ -6,7 +6,6 @@
 from lib.modules.fingerprints import FingerprintPlugin, Fingerprints
 from lib.utils.container import Services
 from lib.utils.output import Output
-from lib.utils.datastore import Datastore
 from lib.request.request import SingleRequest