Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Scala 3.2.0 (and thus Scala.js 1.9.0) to avoid sourcemaps bug #13

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

raquo
Copy link
Contributor

@raquo raquo commented Sep 27, 2022

This one: scala/scala3#14240

As per todays discussion in scala-js Discord, I need to upgrade all dependencies of Laminar to Scala 3.2.0, which in turn requires upgrading them to Scala.js 1.9.0.

I'm not 100% sure how to set the Scala.js version that URL-DSL is published with. I updated the "default" Scala.js version to the new minimum workable one.

I technically don't need URL-DSL for Laminar itself, but I do need it for Waypoint. Could you please release this as 0.4.1?

@raquo raquo changed the title Bump to Scala 3.2.0 (and thus Scala.js 1.9.0) to avoid sourcemaps off-by-one bug Bump to Scala 3.2.0 (and thus Scala.js 1.9.0) to avoid sourcemaps bug Sep 27, 2022
@sherpal
Copy link
Owner

sherpal commented Oct 1, 2022

Thanks!
I need to refresh the setup for publishing the library, I'm planning of doing that the coming week. Sorry for the delay...

@sherpal sherpal merged commit ce2a44c into sherpal:master Oct 1, 2022
@raquo
Copy link
Contributor Author

raquo commented Oct 1, 2022

No problem, thanks!

@sherpal
Copy link
Owner

sherpal commented Oct 14, 2022

Sorry for the delay!
I wanted to put sbt cli release in place. It's now done but I messed up twice and I had to go straight up to 0.4.3 🤦 (then I also had no access to my github account for a few days...)

In any case, the artifacts are available, version 0.4.3.
I will also make a PR with instructions to release a new one.

@raquo
Copy link
Contributor Author

raquo commented Oct 15, 2022

Awesome, thanks, no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants