Document optional params #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: edited description to fix a typos: forgot the |
|
Yes, indeed, it seems like a necessary addition to the docs. For your question, it should be quite easy to fix, I will try to have a look this week-end/week. |
- bug: parsing empty query parameter like `http://localhost:8080?foo=`as String returned None instead of Some("").
- improve: check if query parameter's key is valid. `http://localhost:8080?=value` was parsed into "" -> Param(value).
|
Hi, I made a small fix for this. raquo#1 |
Fix parsing empty query string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the more popular URL-DSL questions I've seen is how to make optional params so I added a short but explicit line about that in the readme.
I also added some test assertions to check my own understanding. Tests currently fail because the roundtrip does not work for
Some("")in case of an optional String param. What I mean is: if you haveparam[String]("empty").?, and put the valueSome("")into it, it will add"empty="to the URL, which is expected. However, if you try to parse this URL back into the same pattern, you will getNoneinstead ofSome("").Is it possible to fix this, so that such a URL decodes as
Some("")?