-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process dies when running with https after http request #10
Labels
bug
Something isn't working
Comments
alecalve
changed the title
Process dies when running with https after http request on GET / happens
Process dies when running with https after http request
Sep 3, 2018
Ugh. This is probably related to 62798ca. Which version of nodejs are you running? Are you able to access the server using |
|
Looks like this was broken due to some changes introduced in node v9.6. 13c2bff should fix this. Can you run from master and confirm this works? $ git clone https://github.com/shesek/spark-wallet && cd spark-wallet \
&& npm install && npm start -- --host 0.0.0.0 |
It does! Thanks for the quick fix. |
shesek
added a commit
that referenced
this issue
Sep 6, 2018
Make sure to set `socket.server` to the appropriate server handler before delegating. This became required as of node v9.6, due to the changes introduced in nodejs/node@c247cb0 Fixes #10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
running this in another term:
Logs are:
The text was updated successfully, but these errors were encountered: