Add on-chain withdraw UI #69
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shesek
reviewed
Mar 4, 2019
client/src/model.js
Outdated
| @@ -68,6 +69,7 @@ module.exports = ({ dismiss$, togExp$, togTheme$, togUnit$, page$, goHome$, goRe | |||
| , outgoing$.map(p => [ 'success', `Sent payment of @{{${p.msatoshi}}}` ]) | |||
| , funded$.map(c => [ 'success', `Opening channel for @{{${c.chan.msatoshi_total}}}, awaiting on-chain confirmation` ]) | |||
| , closed$.map(c => [ 'success', `Channel ${c.chan.short_channel_id || c.chan.channel_id} is closing` ]) | |||
| , withdrawn$.map(w => [ 'success', `Withdraw completed. t word-wrap: break-word;word-wrap: break-word; xid: ${w.txid}` ]) | |||
There was a problem hiding this comment.
Looks like something slipped in here?
There was a problem hiding this comment.
"Completed" could imply "confirmed", which isn't true at this point. How about "sent" instead "completed"?
client/src/views/index.js
Outdated
| @@ -5,6 +5,7 @@ module.exports = { | |||
| , ...require('./recv') | |||
| , ...require('./node') | |||
| , ...require('./channels') | |||
| , ...require('./onchain') | |||
| , ...require('./deposit') | |||
| , ...require('./withdraw') | |||
There was a problem hiding this comment.
Maybe have both views under onchain.js?
client/src/intent.js
Outdated
| // Withdraw | ||
| , execWithdraw$ = submit('[do=exec-withdraw]') | ||
| .map(d => ({ ...d, amount_sat: toSatCapacity(d.amount_sat) })) | ||
| , withdrawAll$ = on('[name=withdraw-all]', 'input') |
There was a problem hiding this comment.
Perhaps fundMaxChan$ and withdrawAll$ could be unified to a single stream of fundMax$, used both in the channel creation and withdraw pages?
There was a problem hiding this comment.
Is there a better way?
spark-wallet/client/src/intent.js
Line 78 in b7d9f70
client/src/rpc.js
Outdated
| @@ -30,6 +30,7 @@ exports.parseRes = ({ HTTP, SSE }) => { | |||
| , invoice$: reply('invoice').map(r => ({ ...r.body, ...r.request.ctx })) | |||
| , outgoing$: reply('pay').map(r => ({ ...r.body, ...r.request.ctx })) | |||
| , newaddr$: reply('newaddr').map(r => ({ address: r.body.address, type: r.request.send.params[0] })) | |||
| , withdrawn$: reply('withdraw').map(r => ({tx: r.body.tx, txid: r.body.txid})) | |||
There was a problem hiding this comment.
We don't have use for the full tx, we can keep just the txid.
shesek
force-pushed
the
master
branch
2 times, most recently
from
48176a7
to
f1a684f
Compare
piqjen-1xofFi-sikxyh
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.