Migrate GandiProvider to new LiveDns api #639
Conversation
|
This appears to be a disruptive change to users using v4, has it been tested to be OK? |
i tested my new version since i'm generating certificate for my company with my new fork and it's working great ! But for users on v4 i can't test it since my company is on v5. I'm just sure that the current version is not working on gandi v5 (the security header itself has changed from X-API-KEY to classic Authorization for example). If you prefer i can add a option like UseLiveDNS in the Gandi Provider which will be at false by default and handle the two apis (v4 and v5) in the provider |
bhubert
force-pushed
the
master
branch
2 times, most recently
from
a6b2b5f
to
4d6c965
Compare
|
@shibayan I reworked the code to make it work with legacy api by default and allow new gandi users to use the new api |
|
Do not change the existing Gandi DNS implementation, but add the new implementation as GandiV5 |
The old one was already using "V5" in its path, its not really the version that changed, its more gandi that created new api endpoints (that started with v5). So i changed as you asked by adding a new Provider but i called it GandiLiveDnsProvider and not GandiV5. Hope it will suit you, thanks for all your fast feedbacks ! |
|
@shibayan everything looks green, do you know when you will find time to package a new version ? i'd rather use an official version than my fork on production. thanks ! |
|
@shibayan thanks for the validation ! and thanks for all your hard work on this project ! |
Gandi API has changed and migrate to new endpoints