Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7 - S3 plugins : fix Radosgw bug + default scheme S3 client #297

Closed
wants to merge 1 commit into from

Conversation

nabbar
Copy link

@nabbar nabbar commented Jul 4, 2017

Hi,

I have made this update of branch v7 to allow specify the default scheme for S3 plugins and update the minio-go lib to fix bug with radosGW S3.

Details of updates :

  • Transform the hard-coded secure mode false in S3client as a config options to specify a secure S3 connection (default value is set to false for compat.)
  • Fix S3 RadosGW bug (#629 & #630) :
    • Bump library github.com/minio/minio-go to release 2.1.0 in Godeps/Godeps.json
    • Update folder vendor/github.com/minio/minio-go (using godep tools)

(Same as PR #296 but for v7 branch)

…tions to allow specify a secure connection as true

Bump Godep Lib github.com/minio/minio-go to release v2.1.0 / rev : 2f03abaa07d8bc57faef16cda7655ea62a7e0bed to fix ceph S3 issues
Update vendor/github.com/minio/minio-go
@jhunt
Copy link
Contributor

jhunt commented Jul 4, 2017

Is this materially different from the PR you put in against the v6.x branch? (v7 is experimental, and will get periodic merge-backs from v6.x)

@nabbar
Copy link
Author

nabbar commented Jul 4, 2017

OK, good news :)
so I close this PR and we just keep the PR for the branch 6.x

@nabbar nabbar closed this Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants